Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboarding clicksend destination #3486

Merged
merged 9 commits into from
Jul 1, 2024
Merged

feat: onboarding clicksend destination #3486

merged 9 commits into from
Jul 1, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Jun 19, 2024

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2210

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (d655fd1) to head (657f828).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3486      +/-   ##
===========================================
+ Coverage    88.05%   88.10%   +0.05%     
===========================================
  Files          577      580       +3     
  Lines        31164    31301     +137     
  Branches      7430     7464      +34     
===========================================
+ Hits         27440    27577     +137     
  Misses        3414     3414              
  Partials       310      310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gauravudia
Gauravudia previously approved these changes Jun 20, 2024
Copy link

Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I only reviewed the templates, please get someone to review the test cases

@shrouti1507 shrouti1507 merged commit 85c8ea7 into develop Jul 1, 2024
17 checks passed
@shrouti1507 shrouti1507 deleted the feat.clickSend branch July 1, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants